ablab / VerityMap

GNU General Public License v3.0
30 stars 5 forks source link

check for non-zero exit in mapper.py #20

Closed ptrebert closed 2 years ago

ptrebert commented 2 years ago

Hi, may I suggest that you change this line

https://github.com/ablab/VerityMap/blob/8d241f4750b71ee87669f41b3c976c4cbbb2be1d/veritymap/py_src/mapper.py#L42

to subprocess.check_call or to explicitly check the returncode attribute? In the current form, errors occurring in the subprocess will go unnoticed.

Best, Peter

seryrzu commented 2 years ago

Thank you for the suggestion! Addressed in https://github.com/ablab/VerityMap/pull/21