ablaom / MLJTutorial.jl

Notebooks for introducing the machine learning toolbox MLJ (Machine Learning in Julia)
MIT License
25 stars 3 forks source link

Pluto notebook for part 01 adapted - is now functional #4

Closed roland-KA closed 2 years ago

roland-KA commented 2 years ago

The notebook for part 01 of the tutorial (notebook.pluto.jl) has been adapted, so that is now fully functional for use with Pluto.

Among other things

roland-KA commented 2 years ago

@ablaom, as a first example, I have adapted the Pluto notebook for part 01 of the tutorial. If these changes are ok with you, I could adapt the remaining Pluto notebooks in the same way.

ablaom commented 2 years ago

@roland-KA That's awesome, many thanks!

My only concern is this introduces parallel maintenance for the different flavors of notebooks, rather than generating all the notebooks from a single Literate.jl script, notebook.jl, which was the original vision. However, achieving this vision is tricky, which is why I kind of gave up on the Pluto notebooks.

Unless you have a better suggestion, let's live with the dual maintenance issue and see how it goes. I'll be very happy to have your help converting the remaining notebooks - I just can't make a water-tight commitment to updating them along with the others in the future.

How's that sound?

ablaom commented 2 years ago

By the way, I just tested out your tutorial and it looks very nice.

I've added an option pluto() to launch the first tutorial.

roland-KA commented 2 years ago

@roland-KA That's awesome, many thanks!

My only concern is this introduces parallel maintenance for the different flavors of notebooks, rather than generating all the notebooks from a single Literate.jl script, notebook.jl, which was the original vision. However, achieving this vision is tricky, which is why I kind of gave up on the Pluto notebooks.

Unless you have a better suggestion, let's live with the dual maintenance issue and see how it goes. I'll be very happy to have your help converting the remaining notebooks - I just can't make a water-tight commitment to updating them along with the others in the future.

How's that sound?

This concern came also to my mind. But I don't think that it is possible to achieve a completely automated conversion. And even if it would be possible, I doubt that the usability of the resulting notebooks would be of good quality. Especially with a tutorial you address people who are typically not on an expert level. So I think it's worth the extra effort and your suggestion sounds good to me. 👍

I will convert the remaining parts of the tutorial and if my time allows, I will support also future adaptions (of course hoping, that MLJ won't introduce too many code braking changes in the future 😀).

ablaom commented 2 years ago

Sounds, good, thanks!