Better comment formatting

able-bio / suggestion-box

A place to submit issues for bugs, feature requests and other ideas related to Able.

https://able.bio

4 stars 0 forks source link

Better comment formatting #19

Open RhettTrickett opened 5 years ago

RhettTrickett commented 5 years ago

Mentioned by @drenther and @Minenash.

Comments could be better formatted to show line breaks, auto-links and so on.

RhettTrickett commented 5 years ago

Comments now support markdown syntax and auto-linking. All previous comments have been updated so they are not more clearly formatted. Let me know if we need anything else on this one.

Minenash commented 5 years ago

One linebreak is ignored, but two works (basically how Reddit does it). Is this intentional?

If I post a comment to an article, the markdown doesn't apply until refresh. Replies to comments work fine though.

If a comment with replies is deleted, it will visually remove the comment, and won't be replaced with the comment removed placeholder until refresh.

If a deleted comment's replies are also deleted, the comment will still have the placeholder instead of being fully removed.

How does one quote with markdown, the standard > doesn't work.

RhettTrickett commented 5 years ago

Fair points. I'll re-open this to sort these out.

RhettTrickett commented 5 years ago

Hi @Minenash,

I've now put some time into fixing some of these.

[x] According to the markdown spec we use, line breaks require the line to end with two or more spaces. I've added a tooltip that appears with a link to markdown syntax when you click into the comment box.
[x] New comments will now appear instantly as rendered markdown.
[ ] Updating a parent comments contents with 'Deleted' text instead of just removing is a lot of work. Not sure it's the best use of time right now but might come back to it when I have some spare time.
[ ] I can't replicate the issue of child comments not being fully removed. Are you sure this is happening and if so could you give details of how I can replicate this.
[x] Markdown quotes should now work.

Let me know if you're still able to replicate that child comments issue or if you're happy for me to close this. Thanks!

Minenash commented 5 years ago

I can't replicate the issue of child comments not being fully removed. Are you sure this is happening and if so could you give details of how I can replicate this.

If I comment is deleted, then it's removed and not replaced with a placeholder. However, if their are child comments, then the parent comment won't be removed, but is replaced with a placeholder.

If a deleted comment has child comments, and all child comments are deleted (and removed because they don't have any child comments), then the parent comment (the one that has no more child comments) is still a placeholder instead of being removed.

Video: https://youtu.be/i4-bcNztaus