search

ableev / Zabbix-in-Telegram

Zabbix Notifications with graphs in Telegram
MIT License
778 stars 233 forks source link

Option to send single message with graph instead of two. #47

Closed imraro closed 6 years ago

imraro commented 8 years ago

Current implementation: before

proposal: after

ableev commented 8 years ago

It was one message, but you don't understand what it is. It is not message, it is photo with caption, which is not text. It doesn't support code formatting and so on.

imraro commented 8 years ago

It was one message, but you don't understand what it is.

I understand, but it's still looks like two messages, isn't it? )

It is not message, it is photo with caption, which is not text. It doesn't support code formatting and so on.

Agree, but it can reproduce more solid notification for those who don't need formatting,

P.S.: I'm asking for the option, not for mandatory implementation. P.P.S: Thank you for good tool, independently of this request!

ableev commented 8 years ago

In classic ways of messaging you have attachments. E-mail has attachments, multiple of them. Facebook/VK messages have attachments. Ticket systems have attachments.

Telegram doesn't have it, it is completely different methods. Even more: captions for photos are clipped to 120 symbols, it is not enough even for default zabbix action.

P.S. Ok, I will make an option for that. P.P.S. Thank you for feedback. :)

imraro commented 8 years ago

Thank you!

...captions for photos are clipped to 120 symbols...

200 symbols, based on: https://core.telegram.org/bots/api and https://github.com/ableev/Zabbix-in-Telegram/issues/14 ))

Vanav commented 7 years ago

Most annoying in current implementation is that Telegram clients notification always say "Photo", not the text of alert. The other workaround would be to send the photo first, then the alert message?

ableev commented 7 years ago

@Vanav in the process of bringing back one message option.

Vanav commented 7 years ago

Maybe need a separate issue, but if I use this guide https://github.com/ableev/Zabbix-in-Telegram/wiki/Trigger-severity-as-Emoji and set subject line like this: "[Emoji-Severity] [Time] [PROBLEM/OK] [Description]", then option to edit last message doesn't work, because your code expects subject as "[PROBLEM/OK] [Description]".

Varrkan82 commented 7 years ago

Confirmed inability to edit messages.

ableev commented 7 years ago

@Vanav @Varrkan82 this feature hasn't worked since the first implementation. In case you have more then one recipients – it's unable to change previous message. Plus, there was a lot of strange code for that method. Will do another way of doing it, but a bit later. Sorry, guys.