ably-forks / laravel-echo

Laravel Echo library for beautiful Pusher and Ably integration.
https://laravel.com/docs/broadcasting#client-side-installation
MIT License
12 stars 4 forks source link

Update/Sync project wrt origin #21

Closed sacOO7 closed 1 year ago

sacOO7 commented 1 year ago
sync-by-unito[bot] commented 1 year ago

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3512

aasiph commented 1 year ago

Please fix the typings path also.

sacOO7 commented 1 year ago

@aasiph I didn't get what you meant by typings path? If you have a corrective suggestion to put at right path, you can put here

aasiph commented 1 year ago

@sacOO7 What i am trying to say is that the types path in package.json is "types": "dist/echo.d.ts". where as i see all typings declaration files in "dist/src/"

Check below image. Code_MzSaQRFAom

right now i am directly importing the classimport Echo from '@ably/laravel-echo/src/echo';

sacOO7 commented 1 year ago

Okay, I will check and fix it : )