.ez build file + RabbitMQ 3.7.* support

mattheworiordan commented 6 years ago

@SimonWoolf we should really get your changes upstreamed, see https://github.com/rabbitmq/rabbitmq-auth-backend-http/pull/68. I hope that gets accepted.

I am trying to upgrade RabbitMQ to 3.7.* but hit an issue with this error when building the container:

warning: the VM is running with native name encoding of latin1 which may cause Elixir to malfunction as it expects utf8. Please ensure your locale is set to UTF-8 (which can be verified by running "locale" in your shell)
Error:
{error,{missing_dependencies,[mochiweb],[rabbitmq_auth_backend_http]}}
 Stacktrace [{rabbit_plugins,ensure_dependencies,1,
                 [{file,"src/rabbit_plugins.erl"},{line,263}]},
             {'Elixir.RabbitMQ.CLI.Plugins.Helpers',list,1,
                 [{file,"lib/rabbitmq/cli/plugins/plugins_helpers.ex"},
                  {line,50}]},
             {'Elixir.RabbitMQ.CLI.Plugins.Helpers',validate_plugins,2,
                 [{file,"lib/rabbitmq/cli/plugins/plugins_helpers.ex"},
                  {line,122}]},
             {'Elixir.RabbitMQ.CLI.Plugins.Commands.EnableCommand',run,2,
                 [{file,"lib/rabbitmq/cli/plugins/commands/enable_command.ex"},
                  {line,75}]},
             {'Elixir.RabbitMQCtl',maybe_run_command,3,
                 [{file,"lib/rabbitmqctl.ex"},{line,113}]},
             {'Elixir.RabbitMQCtl','-exec_command/2-fun-0-',5,
                 [{file,"lib/rabbitmqctl.ex"},{line,80}]},
             {'Elixir.RabbitMQCtl',main,1,
                 [{file,"lib/rabbitmqctl.ex"},{line,43}]},
             {'Elixir.Kernel.CLI','-exec_fun/2-fun-0-',3,
                 [{file,"lib/kernel/cli.ex"},{line,105}]}]
The command '/bin/sh -c rabbitmq-plugins enable --offline rabbitmq_management' returned a non-zero code: 70

I assumed we need to upgrade this plugin, but I have a few questions or issues I need your help with:

[ ] Simply building a new .ez file is unfamiliar to me and there are no easy to build this. I tried make and make dist but they fail with erlang.mk:26: Please upgrade to GNU Make 4 or later: https://erlang.mk/guide/installation.html, DEP rabbit, ERROR: Repository not found., fatal: Could not read from remote repository..
[ ] I am not sure if we can explicitly include this plugin if the plugin is now bundled in 3.7. Assuming it is, do we not now have the 201 issue.

I would appreciate some help here as I am out of my comfort zone with this toolchain I am afraid.

mattheworiordan commented 6 years ago

@SimonWoolf the alternative is in fact to no longer have this fork at all of course, and drop the use of 201 on all realtime auth AMQP endpoints. This is preferable in fact as it means we can go with a more "vanilla" set up. WDYT?

mattheworiordan commented 6 years ago

See https://github.com/rabbitmq/rabbitmq-auth-backend-http/commit/a908effd7bc366f3f902dcc3dd2a3e1f592dce8a

ably-forks / rabbitmq-auth-backend-http

.ez build file + RabbitMQ 3.7.* support #1