ably / ably-asset-tracking-android

Android client SDKs for the Ably Asset Tracking service.
Apache License 2.0
13 stars 6 forks source link

Add a flag to resolution for enabling/disabling sending skipped location updates on per trackable levels. #296

Open kavalerov opened 3 years ago

kavalerov commented 3 years ago

This is in continuation of https://github.com/ably/ably-asset-tracking-android/pull/292#issuecomment-823096116

┆Issue is synchronized with this Jira Task by Unito

KacperKluka commented 3 years ago

@kavalerov do we really mean to add a flag for the intermediateLocations or are we thinking about skippedLocations or maybe both? :thinking:

kavalerov commented 3 years ago

I meant this in the context of this suggestion from you:

Goal: Add much complex logic for choosing if we want to collect and send the skipped locations (i.e. if no subscribers are watching). Allow the subscribers to request sending those skipped locations. What should be done: I'd say that in this case, we need to keep track of this preference for each trackable separately. Then since it's so closely related to the Resolution perhaps this is the correct place to put it? We could add a flag sendSkippedLocations to the Resolution that would just enable or disable skipped locations. In the future, we might extend this by allowing to provide minimumDisplacement and desiredInterval for those skipped locations (not sure if that's to any use though).

So, based on this I think this is more about SkippedLocations

KacperKluka commented 2 years ago

We've decided to put this on hold for now, as we do not see any practical use cases for this feature. One of the main goals of AAT is to provide a smooth experience which is accomplished with the help of the skippedLocations list. The only reason someone would not like to include them in the messages is to send fewer data to save some bandwidth. Until a specific request for this feature arises we would prefer to not add more complexity to the SDK that potentially won't be used at all.