search

ably / ably-asset-tracking-common

Common resources used by the Ably Asset Tracking SDKs.
Apache License 2.0
3 stars 3 forks source link

Remove the type field from the `EnhancedLocationUpdate` #69

Open KacperKluka opened 1 year ago

KacperKluka commented 1 year ago

This issue is connected to https://github.com/ably/ably-asset-tracking-common/issues/46.

We have a type field in the EnhancedLocationUpdate class. This field can be either ACTUAL or PREDICTED and is meant to inform users whether a location was predicted by the Mapbox SDK or whether it is an actual location update from the GPS. There are a few issues with this:

  1. We were advised by Mapbox to disable predictions in the SDK so we should never receive a predicted location.
  2. The AAT Android has wrongly implemented detecting if a location is predicted and now we will see locations marked as PREDICTED when in reality they are not predicted. (related issue https://github.com/ably/ably-asset-tracking-android/issues/828)
  3. The AAT Swift always sets the type field to ACTUAL
  4. We're not sure if one can tell whether a location is predicted or not. (We've asked Mapbox to verify this https://github.com/mapbox-collab/Ably-DH-Collab/issues/23)

Given the above, it looks like the type field brings more noise than helpful information, so perhaps we should consider whether it should be removed or changed in some way?

sync-by-unito[bot] commented 1 year ago

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3130