ably / ably-chat-js

Ably Chat SDK for JavaScript to build chat experiences at scale
https://ably-livestream-chat-demo.vercel.app/
Apache License 2.0
8 stars 0 forks source link

deps: remove dependency on structuredClone #347

Closed AndyTWF closed 1 month ago

AndyTWF commented 1 month ago

Context

CHA-494

Description

This method is not available in React Native runtimes, so replace it with the lodash.cloneDeep function instead, which is entirely self-contained.

Checklist

Testing Instructions (Optional)

N/A

github-actions[bot] commented 1 month ago

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 94.17% (🎯 92%) 2843 / 3019
🟢 Statements 94.17% (🎯 92%) 2843 / 3019
🟢 Functions 93.8% (🎯 93%) 212 / 226
🟢 Branches 94.35% (🎯 93%) 769 / 815
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/core/room.ts 96.28% 98.43% 100% 96.28% 136-137, 349-355
Generated in workflow #1516
splindsay-92 commented 1 month ago

Do we have a check for this? How will we test to ensure any other packages are supported in Native?

Looks like there is a lint tool, perhaps we can make use of that for future-proofing?

AndyTWF commented 1 month ago

Do we have a check for this? How will we test to ensure any other packages are supported in Native?

Looks like there is a lint tool, perhaps we can make use of that for future-proofing?

There is, but it didn't catch it. There's a backlog task to consider tests with Detox/Playwright to cover this. In the meantime there's a smoketest app in ably-js that can be used to demonstrate functionality.