React unhandled rejection errors - Githubissues

ably / ably-chat-js

Ably Chat SDK for JavaScript to build chat experiences at scale

https://ably-livestream-chat-demo.vercel.app/

Apache License 2.0

8 stars 0 forks source link

React unhandled rejection errors #352

Closed AndyTWF closed 1 month ago

AndyTWF commented 1 month ago

Context

Fixes #350

Description

Adds a promise rejection handler in ChatRoomProvider to handle unhandled rejections (due to initialization skips)
Adds a promise rejection handler for getPreviousMessages if the room is released before initialization
Changes the room release before initialization to use an appropriate error code
Avoid error logging in usePresenceListener and useTyping if room is released

Checklist

[x] QA'd by the author.
[x] Unit tests created (if applicable).
[x] Integration tests created (if applicable).
[x] Follow coding style guidelines found here.
[x] TypeDoc updated (if applicable).
[x] (Optional) Update documentation for new features.
[x] Browser tests created (if applicable).
[x] In repo demo app updated (if applicable).

Testing Instructions (Optional)

Open demo app, refresh many times - notice there are no errors (compare to main).

github-actions[bot] commented 1 month ago

Coverage Report

Status	Category	Percentage	Covered / Total
🟢	Lines	94.18% (🎯 92%)	2853 / 3029
🟢	Statements	94.18% (🎯 92%)	2853 / 3029
🟢	Functions	93.39% (🎯 93%)	212 / 227
🟢	Branches	94.25% (🎯 93%)	771 / 818

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/core/errors.ts	100%	100%	0%	100%
src/core/messages.ts	94%	93.1%	100%	94%	363-365, 398-402, 414-418, 535-536
src/core/room.ts	96.2%	98.41%	100%	96.2%	137-138, 346-352
src/react/hooks/use-presence-listener.ts	89.57%	85.71%	100%	89.57%	116-119, 133-136, 159-164, 168-170
src/react/hooks/use-typing.ts	98.85%	93.1%	100%	98.85%	85
src/react/providers/chat-room-provider.tsx	97.61%	90%	100%	97.61%	92

Generated in workflow #1527