ably / ably-chat-js

Ably Chat SDK for JavaScript to build chat experiences at scale
https://ably-livestream-chat-demo.vercel.app/
Apache License 2.0
8 stars 0 forks source link

test: fix occupancy tests #367

Closed AndyTWF closed 2 weeks ago

AndyTWF commented 2 weeks ago

Context

CHA-580

Description

This change fixes the occupancy tests to account for recent changes in Realtime that affect the numbers.

Checklist

Testing Instructions (Optional)

Run tests!

github-actions[bot] commented 2 weeks ago

Coverage Report

Status Category Percentage Covered / Total
🟢 Lines 94.18% (🎯 92%) 2853 / 3029
🟢 Statements 94.18% (🎯 92%) 2853 / 3029
🟢 Functions 93.39% (🎯 93%) 212 / 227
🟢 Branches 94.25% (🎯 93%) 771 / 818
File CoverageNo changed files found.
Generated in workflow #1562 for commit 140cff6 by the Vitest Coverage Report Action
splindsay-92 commented 2 weeks ago

Looks good, but can we get a bit more of an explanation here as to why this fix is needed please?

AndyTWF commented 2 weeks ago

Looks good, but can we get a bit more of an explanation here as to why this fix is needed please?

As this involves internal realtime details, I have DMd you directly :)