search

ably / ably-cocoa

iOS, tvOS and macOS Objective-C and Swift client library SDK for Ably realtime messaging service
https://ably.com/download
Apache License 2.0
45 stars 24 forks source link

Increase minimum supported OS versions to remove warnings when building with Xcode 14 #1511

Open lawrence-forooghian opened 1 year ago

lawrence-forooghian commented 1 year ago

When building with Xcode 14, I get the following warnings:

  • The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions is 11.0 to 16.0.99.
  • The tvOS Simulator deployment target 'TVOS_DEPLOYMENT_TARGET' is set to 10.0, but the range of supported deployment target versions is 11.0 to 16.0.99.
  • The macOS deployment target 'MACOSX_DEPLOYMENT_TARGET' is set to 10.12, but the range of supported deployment target versions is 10.13 to 13.0.99.

It feels pretty safe to me to remove support for these older OS versions even Apple aren't letting us use it as a deployment target any more, and, in the iOS and tvOS case, there are no simulators available for them. QuintinWillison would this count as a "breaking change" in terms of versioning?

┆Issue is synchronized with this Jira Task by Unito

sync-by-unito[bot] commented 1 year ago

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2851

QuintinWillison commented 1 year ago

I definitely think this counts as an incompatible/breaking change to the SDK, so this would be a candidate for us to either "sneak in" in the 1.2 series, or more politely queue up for a v2 major bump. Per our Guidance on Versioning. I don't have strong feelings either way, but others might. Unsure of what impact could be for existing customers, also.

FYI, @mikelee638

lawrence-forooghian commented 1 year ago

This will be fixed by #1630.