search

ably / ably-dotnet

.NET, MAUI, Xamarin, Mono and Unity client library SDK for Ably realtime messaging service
https://ably.com/download
Apache License 2.0
45 stars 22 forks source link

Release/1.2.13 - Upgrade to protocol 2.0 #1261

Closed sacOO7 closed 1 year ago

sacOO7 commented 1 year ago

Implement no-connection-serial

owenpearson commented 1 year ago

@sacOO7 I'm a bit confused by this - the name of the integration/2.0 branch/pr implies that we were releasing this as version 2.0? If there's no breaking changes then at the very least we should update the changelog and PR name to reflect that it's no longer a 2.0 change, but it looks like there are some breaking changes here so I think we need to have a discussion about whether it's appropriate to release this in a patch version

sacOO7 commented 1 year ago

@sacOO7 I'm a bit confused by this - the name of the integration/2.0 branch/pr implies that we were releasing this as version 2.0? If there's no breaking changes then at the very least we should update the changelog and PR name to reflect that it's no longer a 2.0 change, but it looks like there are some breaking changes here so I think we need to have a discussion about whether it's appropriate to release this in a patch version

Though, we have changed lot of things internally, I don't think there are any breaking changes to the public API as such.

owenpearson commented 1 year ago

OK as long as there are no breaking changes then it's cool to release this as a patch version 👍 I still think the changelog entries here are very unhelpful and misleading, for example I would change "integration/2.0" to "Upgrade library to protocol v2" (it would be good to change the actual PR title too). Also I think we should remove changes to the README and CI tests from the changelog since these aren't relevant to library users.

sacOO7 commented 1 year ago

OK as long as there are no breaking changes then it's cool to release this as a patch version 👍 I still think the changelog entries here are very unhelpful and misleading, for example I would change "integration/2.0" to "Upgrade library to protocol v2" (it would be good to change the actual PR title too). Also I think we should remove changes to the README and CI tests from the changelog since these aren't relevant to library users.

Updated!