Implement missing RTP2f - Githubissues

ably / ably-dotnet

.NET, MAUI, Xamarin, Mono and Unity client library SDK for Ably realtime messaging service

https://ably.com/download

Apache License 2.0

45 stars 22 forks source link

Implement missing RTP2f #1277

Open sacOO7 opened 3 months ago

sacOO7 commented 3 months ago

Related to https://github.com/ably/ably-dotnet/pull/147
Fix missing RTP2f same as - Fix missing RTP2f same as https://github.com/ably/ably-cocoa/pull/1891/commits/1d2f015ff007537fd66febc6b28f79c7e2e37468 and https://github.com/ably/ably-cocoa/pull/1891/files

┆Issue is synchronized with this Jira Task by Unito

sacOO7 commented 2 months ago

Also, fix https://github.com/ably/ably-dotnet/issues/1271#issuecomment-1987883093

sacOO7 commented 1 month ago

Make sure msgSerial starts at 0. This is needed for processing ack/nack https://sdk.ably.com/builds/ably/specification/main/features/#RTN7b. At https://github.com/ably/ably-dotnet/blob/092240bfb9d433b50fe52150c612c1c5a999c3ff/src/IO.Ably.Shared/Realtime/Workflows/RealtimeWorkflow.cs#L591. Msgserial is incremented to 1 then it is sent to server ( which kinda seems like a bug )