enhance logging on android part of plugin to be production-ready

ably / ably-flutter

A wrapper around our Cocoa and Java client library SDKs, providing iOS and Android support for those using Flutter and Dart.

https://ably.com/download

Apache License 2.0

60 stars 16 forks source link

enhance logging on android part of plugin to be production-ready #24

Open tiholic opened 4 years ago

tiholic commented 4 years ago

Convert all System.out.println to a production ready logging system, probably SLF4J as suggested by QuintinWillison in this thread: https://github.com/ably/ably-flutter/pull/21#discussion_r462134457

┆Issue is synchronized with this Jira Task by Unito

ikbalkaya commented 2 years ago

Searched the whole plugin for "System.out.*" and only one result appeared System.out.printf("%splatform method not implemented. %n", methodName); In other places it's standard Android logging Log.x. So I will assume that this is still relevant and we want to adopt a standardised logging system we do (maybe we already did) in Kotlin/Java libraries

QuintinWillison commented 2 years ago

Relates to https://github.com/ably/ably-java/issues/64 - though, really, the crux of that is whether we should be adopting SLF4J (LOG4J is just an implementation... vulnerable to flaws, like any other implementation).