search

ably / ably-flutter

A wrapper around our Cocoa and Java client library SDKs, providing iOS and Android support for those using Flutter and Dart.
https://ably.com/download
Apache License 2.0
60 stars 16 forks source link

Set Flutter CI version to ^3.0.0 #403

Closed ikurek closed 2 years ago

ikurek commented 2 years ago

Since ably-flutter is ready to be used with Flutter 3, I've updated the CI workflows to use stable Flutter versions 3.0.x. This is also a blocker for #401 because latest versions of test dependency requires Flutter 3 to run. I've also updated the formatting of YAML files to increase consistency

ikurek commented 2 years ago

Also, what's with the unrelated changes of single quotes to double quotes?

I wanted to align them - my formatters in VS Code and Android Studio always complain that these YAML files aren't properly formatted, so I thought I may make the quotes consistent if I'm changing them anyway. I've removed the changes to quotes, but decided to leave some minor formatting changes (like removing unnecessary whitespace)

ikurek commented 2 years ago

I had to do a minor fix for Flutter lint here: https://github.com/ably/ably-flutter/pull/403/commits/ff15f01455a3e7febffd2947e3bd1e3e98444792, so the CI check doesn't fail