search

ably / ably-flutter

A wrapper around our Cocoa and Java client library SDKs, providing iOS and Android support for those using Flutter and Dart.
https://ably.com/download
Apache License 2.0
60 stars 16 forks source link

Main thread fix #431

Closed ikbalkaya closed 2 years ago

ikbalkaya commented 2 years ago

This is a regression fix from https://github.com/ably/ably-flutter/pull/291

This fix will prevent calls from main thread but above ANR issue will resurface. Future works in https://github.com/ably/ably-flutter/issues/339 should make that issue disappear

Closes https://github.com/ably/ably-flutter/issues/429

KacperKluka commented 2 years ago

@ikbalkaya are you planning to also fix that ANR issue that is being reintroduced to the SDK with this PR? It would not be good to make a new release that deliberately adds a bug that we've fixed before :sweat_smile:

ikbalkaya commented 2 years ago

@ikbalkaya are you planning to also fix that ANR issue that is being reintroduced to the SDK with this PR? It would not be good to make a new release that deliberately adds a bug that we've fixed before 😅

Yes, it is intended to be resolved when we decouple push notification code from library code as I added in description https://github.com/ably/ably-flutter/issues/339 But for now this bug takes the priority on ANR bug so we want to fix this. More discussion on this internal message