search

ably / ably-go

Go client library SDK for Ably realtime messaging service
https://ably.com/download
Apache License 2.0
82 stars 31 forks source link

Test against go 1.19, and drop support for 1.17 #563

Closed amnonbc closed 1 year ago

amnonbc commented 1 year ago

See https://github.com/ably/ably-go#supported-versions-of-go

amnonbc commented 1 year ago

Yet to see what CI checks are failing and why...

go 1.19 slightly changes the output of gofmt (in order to acomodate, links, markdown etc.) So this occasionally changes the output of gofmt...

I can't really think of any fix other than removing this test, or only run it for go-1.19 and perhaps putting it back, once go 1.20 comes out and we have obsoleted 1.18 and run gofmt on everything (which is something I don't want to do while other folk have PRs in flight).

What do you think? We do want to ensure that all code has passed gofmt, but we have got to ensure that we support the the latest Go.

however I do wonder if this line in go.mod should also be modified as part of this change.

I don't think it matters, until we start using go-1.18 or 1.19 language features (e.g. Generics).