ably / ably-go

Go client library SDK for Ably realtime messaging service
https://ably.com/download
Apache License 2.0
81 stars 31 forks source link

Inconsistent codebase state around whether `SUSPENDED` channel state is implemented #568

Open QuintinWillison opened 1 year ago

QuintinWillison commented 1 year ago

Our readme states:

There is no channel suspended state; this means that the client will not automatically reattach to channels if a connection becomes suspended and then resumes, and presence members associated with the client will not be automatically re-entered.

A code search for "SUSPENDED" reveals a few TODO comments against channel state code.

Also, concept of "unimplemented test" was introduced at some point to the backlog. I'm going to close all of these issues as they add no value to the backlog (the work to be done is under this issue) however I am recording them here for reference:

In the absence of deeper analysis I'm going to mark this issue as a bug for now.

┆Issue is synchronized with this Jira Task by Unito

sync-by-unito[bot] commented 1 year ago

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3138

sacOO7 commented 2 months ago

Update transitioner_integration_test -> channelTransitioner that transitions channel to suspended from attaching