Implement missing RTP2f - Githubissues

ably / ably-go

Go client library SDK for Ably realtime messaging service

https://ably.com/download

Apache License 2.0

81 stars 31 forks source link

Implement missing RTP2f #636

Open sacOO7 opened 5 months ago

sacOO7 commented 5 months ago

Fix missing RTP2f same as - Fix missing RTP2f same as https://github.com/ably/ably-cocoa/pull/1891/commits/1d2f015ff007537fd66febc6b28f79c7e2e37468 and https://github.com/ably/ably-cocoa/pull/1891/files

┆Issue is synchronized with this Jira Task by Unito

sacOO7 commented 3 months ago

Presence queue was added as a part of the commit https://github.com/ably/ably-go/commit/c41ddeb3cc3abbe6c1433b3504ea54515a9fa910. This means there is no need to maintain channel queue as per spec. It can be completely removed altogether. This has been identified while working on ably-ruby. See comment -> https://github.com/ably/ably-ruby/issues/407#issuecomment-2129397204

Note - As per https://github.com/ably/ably-go/blob/dd8236fc301eb078803e83efee7615f3ba133341/ably/realtime_channel.go#L272, for both ConnectionStateConnected and ConnectionStateFailed, we need to flush and fail the presence queue as well. We used to do it before this commit was added. Currently, we only do it when channel is detached, failed or suspended. Also, need to check if this is really needed