Code cleanup and warning checkup

ably / ably-java

Java, Android, Clojure and Scala client library SDK for Ably realtime messaging service

https://ably.com/download

Apache License 2.0

85 stars 39 forks source link

Code cleanup and warning checkup #848

Open qsdigor opened 2 years ago

qsdigor commented 2 years ago

While working on implementation/version-2 I noticed many deprecated methods, lousy formatting, and other warnings.

Running lint revealed 133 errors, 2.297 warnings, 56 week-warnings, and 1.393 typos. While a lot of them are not valid warnings a lot of them are and should be addressed.

We should run code formatting and optimize imports so everything is tidy.

┆Issue is synchronized with this Jira Task by Unito

sync-by-unito[bot] commented 2 years ago

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2866

QuintinWillison commented 2 years ago

Work on this issue will need to include adding these lint checks to CI in our check workflow. I understand from @qsdigor that the command he's using locally (which we don't currently run in CI) is ./gradlew lint or in IntelliJ "toolbar -> code -> inspect code -> whole project -> ok".