search

ably / ably-php

PHP client library SDK for Ably realtime messaging service
https://ably.com/download
Apache License 2.0
49 stars 10 forks source link

Add support for MsgPack #161

Closed AmirQSD closed 2 years ago

AmirQSD commented 2 years ago

I had to alter a few tests that included base64 decode, since with messagepack, binary data is sent as bytes, without the need to specify the base64 encoding.

qsdstefan commented 2 years ago

Looks good for now, but you will need to update .github/workflows/check.yml by adding protocol: [ 'json', 'msgpack' ] to the matrix, then under env you should pass PROTOCOL as PROTOCOL: ${{ matrix.protocol }} to provide the environment variable in the final workflow step which is Run test suite See check.yml#L14 for details

sacOO7 commented 2 years ago

Other than few changes, looks good to me overall 👍