Fix PHP 8.2 issues - Githubissues

driesvints commented 1 year ago

This PR replaces https://github.com/ably/ably-php/pull/166.

In this PR I've:

Added a new 8.2 build that, for now, ignores platform requirements (to be revised once a stable PHP 8.2 version is out)
Enabled PHP to throw deprecation notices in the CI build
Instructed PHPUnit to treat deprecations as errors so the PHP 8.2 deprecations can be checked for
Added missing properties or the #[\AllowDynamicProperties] attribute (see https://wiki.php.net/rfc/deprecate_dynamic_properties)
Removed parent calls in callables (see https://github.com/php/php-src/blob/87862578cb9fa1e14e52d981f67b3e0b94c19d22/UPGRADING#L157-L167)
Converted implicit float conversion to int to explicit conversion in Auth.php

driesvints commented 1 year ago

@sacOO7 I finally managed to get everything ready. Feel free to ask questions if you have any.

driesvints commented 1 year ago

Hi all. Is there any chance you could merge and tag these changes? We're so close to a passing build on Laravel and this PR is the very last thing that's keeping us from it 🙂

driesvints commented 1 year ago

Thanks all!

sacOO7 commented 1 year ago

Thanks @driesvints and others for merging the PR : )

owenpearson commented 1 year ago

@driesvints We've just released 1.1.9 with these changes

ably / ably-php

Fix PHP 8.2 issues #167