Improve PHP 8.2 compatibility and testing

ably / ably-php

PHP client library SDK for Ably realtime messaging service

https://ably.com/download

Apache License 2.0

49 stars 10 forks source link

Closed AndyTWF closed 1 year ago

AndyTWF commented 1 year ago

Adds PHP 8.2 compatibility without platform-reqs concessions
Updates a flakey test to allow for differences between CI and Server time
Removes use of deprecated PHPUnit method (and introduces a wrapper that we can remove once PHP 7.2 is dropped from CI)

Fixes #164

sacOO7 commented 1 year ago

Can you update file name for check.yml to build-test.yml ?

sacOO7 commented 1 year ago

Also, check if there is a need to update composer.json.

AndyTWF commented 1 year ago

I believe that check.yml is consistent with the filename conventions in https://github.com/ably/engineering/blob/main/sdk/github.md#filenames

AndyTWF commented 1 year ago

composer.json appears to be fine - but will double check