search

ably / ably-php

PHP client library SDK for Ably realtime messaging service
https://ably.com/download
Apache License 2.0
51 stars 10 forks source link

Use "http_proxy" env variable if defined to set the CURLOPT_PROXY opt… #51

Closed DamienHarper closed 6 years ago

DamienHarper commented 6 years ago

…ion.

funkyboy commented 6 years ago

@DamienHarper Thanks a lot for this contribution!

This looks good to me. And the failures in CI seem not related to the change. @jdavid WDYT?

DamienHarper commented 6 years ago

@funkyboy @jdavid thanks for your comments, may I ask you when do you plan to merge this PR and release?

funkyboy commented 6 years ago

@DamienHarper We will merge this first, then rebase this branch on master and see how tests go. Soon :)

funkyboy commented 6 years ago

@DamienHarper PR has been merged Please sync your fork with our new master and push updates to this PR so we'll see how tests go.

Thanks again.

DamienHarper commented 6 years ago

@funkyboy Done, all green :)

funkyboy commented 6 years ago

@DamienHarper Merged. You deserve some swag :) We'll get in touch. Thanks!

mattheworiordan commented 6 years ago

Thanks @DamienHarper, we appreciate the contribution. Drop us a line at support@ably.io and we'll send over something small as a thanks!