search

ably / ably-php

PHP client library SDK for Ably realtime messaging service
https://ably.com/download
Apache License 2.0
50 stars 10 forks source link

RSH1b2 New push.admin.device_registrations.list_ #68

Closed jdavid closed 5 years ago

jdavid commented 5 years ago

list is a reserved word, so we use list_

paddybyers commented 5 years ago

From Slack:

actually it doesn't work, next() the server returns Link: <./push/deviceRegistrations?limit=1&format=json&offset=0%3A0%3AZmFhNWNjZTM3YmEwYjg0ODlhZGMwMzVmMDc%3D>; rel="next" then ./push/deviceRegistrations?limit=1&format=json&offset=0%3A0%3AZmFhNWNjZTM3YmEwYjg0ODlhZGMwMzVmMDc%3D is resolved against /push/deviceRegistrations returning /push/push/deviceRegistrations?limit=1&format=json&offset=0%3A0%3AZmFhNWNjZTM3YmEwYjg0ODlhZGMwMzVmMDc%3D what produces a 404 error @paddy should I interpret the ./push/deviceRegistrations?limit=1&format=json&offset=0%3A0%3AZmFhNWNjZTM3YmEwYjg0ODlhZGMwMzVmMDc%3D as if it was an absolute path? the code is like that since 2015,

paddy [9:43 AM] @jdavid no, that's a bug. The rel link should be './deviceRegistrations?....

paddybyers commented 5 years ago

@jdavid I think this should be merged, and additional pagination tests added as a separate PR once the realtime issue is resolved.