search

ably / ably-php

PHP client library SDK for Ably realtime messaging service
https://ably.com/download
Apache License 2.0
50 stars 10 forks source link

Push #80

Closed jdavid closed 5 years ago

jdavid commented 5 years ago

Follow up from #79

This is a feature branch, all changes have been reviewed already.

jdavid commented 5 years ago

@mattheworiordan

jdavid commented 5 years ago

So now which are the next steps? Should I change this PR to Ready for review?

mattheworiordan commented 5 years ago

So now which are the next steps? Should I change this PR to Ready for review?

Yes. And @paddybyers or I can merge / approve etc. Thanks,.

mattheworiordan commented 5 years ago

Merged, thanks, should we do a release @jdavid?

mattheworiordan commented 5 years ago

@tomczoink in case anything needs updating in the docs, looks like Push is now supported! 👍

jdavid commented 5 years ago

@mattheworiordan yes I think so, 1.1.2 ?

mattheworiordan commented 5 years ago

I think so, 1.1.2 ?

Sure, if that's the next patch release version. Please confirm when done.

Thanks 🙏

jdavid commented 5 years ago

done https://packagist.org/packages/ably/ably-php#1.1.2

mattheworiordan commented 5 years ago

Awesome, tahnks