search

ably / ably-php

PHP client library SDK for Ably realtime messaging service
https://ably.com/download
Apache License 2.0
51 stars 10 forks source link

Need to support Push payloads in publish() #82

Closed tomczoink closed 4 years ago

tomczoink commented 5 years ago

Per https://docs.ably.io/client-lib-development-guide/features/#RSL6a2

a Message can have extras: { push: { ... }} when published, but the library just silently discards it right now.

mattheworiordan commented 5 years ago

@jdavid is this something you can look at?

mattheworiordan commented 5 years ago

Seems a few spec items are not addressed that were updated in 1.1 for push support, including https://docs.ably.io/client-lib-development-guide/features/#RSL1h, https://docs.ably.io/client-lib-development-guide/features/#TM2i, https://docs.ably.io/client-lib-development-guide/features/#TP3i.

@jdavid please ensure if any of these issues are not addressed in the Python lib that you create an issue there too.

mattheworiordan commented 5 years ago

@jdavid apart from 4a89a52, are you able to:

a) confirm status of this for Python b) confirm that https://github.com/ably/ably-php/issues/82#issuecomment-537694107 is addressed or not?

jdavid commented 4 years ago

Support for RSL6a2 is already done in Python, see https://github.com/ably/ably-python/blob/develop/test/ably/restchannelpublish_test.py#L343

I've implemented RSL1l in both Python and PHP (issue #83)

Regarding RSL1h now in Python a deprecation warning is raised if clientId or extras are used. In PHP I've added a note in the code saying these are deprecated.

Extras in Message (TM2i) is supported in Python, but not in PressenceMessage (TP3i). PHP supports both TM2i and TP3i.

mattheworiordan commented 4 years ago

Ok, great, do you agree we can close this then?

jdavid commented 4 years ago

Yes, I've reviewed TM2 and TP3 in ably-python, added extras to PressenceMessage (TP3i)

Closing