Open Andrioden opened 1 year ago
➤ Automation for Jira commented:
The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3842
The "fix" in my repo is to add the following to my config
pyproject.toml
[[tool.mypy.overrides]]
module = "ably.*"
ignore_missing_imports = true
@Andrioden even I agree with you. Typing surely brings more power to the code. In the subsequent iterations, we will surely cover missing types from the code.
Feel free to raise more suggestions and create a PR if possible : )
Related to #480
Why
I love types, and want everything in python typed as strongly as possible within reason. This creates more readable code and makes refactoring easier and safer. If i debug my code that depend on ably code, i find myself stepping into untyped ably code, this makes it harder to read.
The following import triggers an mypy error
game\utils\event_publisher.py
Running
mypy .
In addition i see the very prominent
Channel.publish
is not typed.My suggestions are
Read more here
┆Issue is synchronized with this Jira Task by Unito