WebSocket code has same incorrect server certificate verification logic as em-http-request

ably / ably-ruby

Ruby client library SDK for Ably realtime messaging service

https://ably.com/download

Apache License 2.0

37 stars 19 forks source link

WebSocket code has same incorrect server certificate verification logic as em-http-request #401

Open lawrence-forooghian opened 6 months ago

lawrence-forooghian commented 6 months ago

The issue described in #396 also exists in our WebSocket code (although it's not currently causing a test failure since we don’t use Let’s Encrypt on our WebSocket endpoint). Fix it.

┆Issue is synchronized with this Jira Task by Unito

sacOO7 commented 5 months ago

Seems similar issue was patched as a part of https://github.com/ably/ably-ruby/pull/234

lawrence-forooghian commented 5 months ago

I might be missing something but I think that #234 just pulls in the verification logic from em-http-request, i.e. the incorrect logic described in #396?