search

ably / ably-ruby

Ruby client library SDK for Ably realtime messaging service
https://ably.com/download
Apache License 2.0
36 stars 19 forks source link

Failing Test - retrieves two pages of messages before channel was attached #414

Closed sacOO7 closed 3 months ago

sacOO7 commented 3 months ago

One of the test started failing on main due to recent changes deployed on sandbox retrieves two pages of messages before channel was attached with error 2024-06-20 17:53:45.015 ERROR [BSoVdP1hrw] An exception in an external block was caught. Ably::Exceptions::InvalidRequest: invalid clientId; requested clientId cannot be wildcard (status: 400, code: 40012) (code: 40012, http status: 400) -> see https://help.ably.io/error/40012 for help

Link to internal discussion - https://ably-real-time.slack.com/archives/C8SPU4589/p1718885475429199

┆Issue is synchronized with this Jira Task by Unito

AndyTWF commented 3 months ago

The fix here will be to prevent the library from sending through * in the X-Ably-ClientId header. Per RSA7e (Thanks Simon for pointing out!) - the client id sent should be a product of the client options and only the client options, not auth.clientId as it currently is.

This will need to go out as part of the 1.2.6 release :)

sacOO7 commented 3 months ago

The fix here will be to prevent the library from sending through * in the X-Ably-ClientId header. Per RSA7e (Thanks Simon for pointing out!) - the client id sent should be a product of the client options and only the client options, not auth.clientId as it currently is.

This will need to go out as part of the 1.2.6 release :)

Thanks @AndyTWF, this is super useful 👍

sacOO7 commented 3 months ago

closed via https://github.com/ably/ably-ruby/pull/418