search

ably / docs

Ably Realtime API documentation
https://ably.com/docs
Apache License 2.0
20 stars 41 forks source link

[WEB-3904]: Prefix meta title with product frontmatter #2246

Closed matt423 closed 4 weeks ago

matt423 commented 4 weeks ago

Description

Using the product frontmatter data or the template's currentProduct, we now prefix the page meta title with the page category, i.e Pub/Sub , API References. For pages without product data, we default to pub_sub.

Screenshot from 2024-08-20 17-30-27

Review

Visit the review app and browse through the pages and check that the titles are showing the prefix as expected.

matt423 commented 4 weeks ago

Looks good! But if I go to https://ably-docs-web-3904-add--8ocjfx.herokuapp.com/docs/sdks or click the SDKs above it doesn't change the title?

Good spot, @aralovelace! I've corrected that here, and have updated the review app if you'd like to re-check, thanks! https://ably-docs-web-3904-add--8ocjfx.herokuapp.com/docs/sdks

m-hulbert commented 4 weeks ago

Looks good @matt423 - there's just one other weird place we generate pages from (e.g. docs/how-to/pub-sub).

matt423 commented 4 weeks ago

@m-hulbert Thanks for flagging! I've amended and re-deployed the preview app