search

ably / engineering

Ably's new home for engineering guidance, including content previously served from Confluence at engineering.ably.com.
https://engineering.ably.com/
Apache License 2.0
2 stars 8 forks source link

Link to GitHub comment in SDK coding standards doesn’t work #6

Open lawrence-forooghian opened 2 years ago

lawrence-forooghian commented 2 years ago

This link points to a PR comment which has already been resolved. When following this link, the browser just leaves you at the top of the PR page without any indication of which was the linked comment.

QuintinWillison commented 2 years ago

@lawrence-forooghian That is annoying. I've had a quick play around and I'm not sure I can find a workaround. Once a conversation has been closed, perhaps only when it's in a bigger and/or closed PR, it seems the comment deep links stop working (presumably because not all the page DOM elements get created immediately, therefore no id exists to link to 🤷).

Thus, unless there's a mechanism GitHub offer that I'm unaware of to realistically link to old comments, then this is unworkable and the fix for this issue is to simply remove this 'dead' link.