search

ably / kafka-connect-ably

Kafka Connector for publishing data from Kafka to Ably
https://ably.com/solutions/extend-kafka-to-the-edge
Apache License 2.0
11 stars 5 forks source link

Checkstyle #74

Open QuintinWillison opened 2 years ago

QuintinWillison commented 2 years ago

In lieu of #21, the Java code needs some linter love.

┆Issue is synchronized with this Jira Uncategorised by Unito

QuintinWillison commented 2 years ago

To add a little more detail... Lack of lint/static-analysis is causing a lot of noise right now in pull requests and I would prefer to allow reviewers to focus on the stuff that matters, and the machines (CI) to catch the rest.

Currently, checkstyle is explicitly disabled in our POM. I had a quick run, locally, at re-enabling it and the checkstyle:checkstyle report isn't pretty. 😞

Screenshot 2022-05-25 at 16 55 32

Consistent formatting is always nice, but I think I'm more concerned around the lack of static analysis to catch the obvious oversights and/or risks.