search

ably / push-example-android

A minimal example/test application demonstrating use of Android push functionality
0 stars 4 forks source link

Remove any rethrow of errors in the UI thread #11

Closed paddybyers closed 2 years ago

amsurana commented 4 years ago

If we are removing exception rethrow, then try..catch block here are no longer needed. We might consider removing these too.

https://github.com/ably/push-example-android/blob/4ed9a371620ec59e845cce3798e1d7264e3e992e/app/src/main/java/io/ably/example/androidpushexample/MainActivity.kt#L820

https://github.com/ably/push-example-android/blob/4ed9a371620ec59e845cce3798e1d7264e3e992e/app/src/main/java/io/ably/example/androidpushexample/MainActivity.kt#L833

QuintinWillison commented 2 years ago

There's no description of what this pull request was aiming to achieve. Furthermore, it seems like participants at the time weren't in agreement either.