search

ably / specification

The Ably features spec for client library SDKs.
Apache License 2.0
0 stars 4 forks source link

Define API for accessing Agent identifier and its components #113

Closed lawrence-forooghian closed 1 year ago

lawrence-forooghian commented 1 year ago

Closes #111. See commit messages for more details.

I'm open to names other than ClientLibraryInfo, given that in fact it returns an combination of information about the library and information about the platform it's running on.

lawrence-forooghian commented 1 year ago

Hi @QuintinWillison, I really appreciate your consideration in addressing the merge conflicts introduced into this PR after https://github.com/ably/specification/pull/116 was merged. However, I prefer not to have merge commits on my feature branches (for reasons that you probably have a good idea of by now based on our previous conversations 😁). I've removed your change and rebased onto main instead.

QuintinWillison commented 1 year ago

Point taken, @lawrence-forooghian, as I do understand you do prefer rebase over merge (per allowance in guidance). 😉

I have, however, added https://github.com/ably/specification/pull/113/commits/0542408673da9575c455b1cd8ecc5dabc7d2fe68 via the GitHub UI in order to verify that checks pass before I (now) merge to main (target) branch. Our branch protection rule for the main (default) branch has "Require branches to be up to date before merging" checked, which I do feel is important.