search

ably / terraform-provider-ably

Ably's Terraform Provider, enabling you to manage your Ably account programmatically.
https://registry.terraform.io/providers/ably/ably
Apache License 2.0
11 stars 2 forks source link

Don't fail when deleting fails #133

Closed Morganamilo closed 1 year ago

Morganamilo commented 1 year ago

When deleting a key that doesn't exist (I don't know how I did this). Terraform hits a 404 because the key is already deleted, this then causes terraform to stop deleting resources, so the rest of the state can't be destroyed.

We should silently ignore deletion errors for 404s.

┆Issue is synchronized with this Jira Task by Unito

Morganamilo commented 1 year ago

I've realised there's more to this. Deleted apps are still readable, so terraform doesn't actually notice if an app has been deleted. You can actually delete an app multiple times with no error. Similarly a key may revoked multiple times, this isn't really an issue for us though.

Other resources seem to 404 when deleted twice as I would expect.

Morganamilo commented 1 year ago

Fixed in #139

sync-by-unito[bot] commented 1 year ago

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-2984