search

ably / terraform-provider-ably

Ably's Terraform Provider, enabling you to manage your Ably account programmatically.
https://registry.terraform.io/providers/ably/ably
Apache License 2.0
11 stars 2 forks source link

Read key from control API #137

Closed Morganamilo closed 2 years ago

Morganamilo commented 2 years ago

The control API seems to now give the actual key data so we can read this instead of state. Other resources still do not expose secrets though, so we still need to read from state there.

EDIT: Thanks to @tete17 for the original proposed fix to this issue (https://github.com/ably/terraform-provider-ably/pull/126), upon which this work was based. We failed to attribute that work here, before this pull request was merged, for which we apologise.

tete17 commented 1 year ago

So this came as a surprise to me.

I won't lie I am pretty disappointed. I pointed out the fact the api responds with the key in my MR https://github.com/ably/terraform-provider-ably/pull/126 and @Morganamilo didn't seem to knew it was happening. They ask me for time to double check the claim. One day later this quick MR comes around with basically the changes I proposed, with less testing done on them and not a single mention/reference. Not even a simple acknowledgement this is a duplicated MR coming from my proposal.

I won't even go into the aspect you guys ⚠️⚠️⚠️STOLE⚠️⚠️⚠️ my source code contributions and didn't even bother with giving me credit. You can see my original commit was basically the same https://github.com/ably/terraform-provider-ably/commit/761cd1296c809a6311ed3625fe83a8e51be6df65 .

I waited 2 months and not a single mention/response...

Having an open source project is more than just publishing the source code of the project. It involves the exchange of code changes between the parties and a level of trust you guys broke by ⚠️⚠️⚠️STEALING⚠️⚠️⚠️ my contributions. Had this been a matter of maintaining intellectual rights over the sources I wouldn't have minded signing the right away.

This is honestly an embarrassing look on @Morganamilo, @ably-terraform-provider and Ably (@mattheworiordan as a representant of the organization).

I will be recommending my organization to move away from your services since you guys can't be trusted as a partner. Don't expect any issues or contributions from me unless a proper apology has been submitted and the situation is rectified.

With much sadness, Miguel Sacristán Izcue

stmoreau commented 1 year ago

Hi Miguel,

I am Stephane, SDK Manager at Ably. The SDK team owns this component and from what I see you are correct - what happened in this instance shouldn't have. I would like to personally apologise and mention that this was unintentional and unusual for us. As a team working exclusively on public repositories, we deeply care and value OSS contributions such as the one you made.

We will definitely review our processes to ensure that mistakes like this don't happen again.

We have as of now taken a few actions, such as editing the opening commentary on this PR and linking it to the work you have done, and editing the previous release notes on GitHub and the changelog tagging you for this change - which is how we typically recognise contributions.

We have also escalated this feedback to the CSM who is working with you from Ably and they will be in touch regarding this.

Thanks, Stephane

tete17 commented 1 year ago

Hey @stmoreau

props where props are due

I appreciate the quick and rapid apologize and correction of the issue. I understand we all make mistakes and specially with this process where an alternative solution was prio first and the pivoted to my original solution.

Thanks for the attributions. I hope it didn't sound like I was an attention seeker in this case. I was honestly more upset about being ignored in the MR and not knowing this was released at all.

Thank you for the apology and good job on the response :+1: Miguel Sacristán Izcue

stmoreau commented 1 year ago

Thank you @tete17 for your understanding that we all make mistakes - and thank you for your patience with us.

We really appreciate your last message. And you did not sound like an attention seeker at all, but someone that is proud of their work and cares for the developer community. We share the same feelings.

If there’s anything else we can do now or in the future, do not hesitate to reach out to me or your CSM.

We will be more than happy to help.

mattheworiordan commented 1 year ago

Thanks @tete17 for flagging this and your understanding. Apologies for the mistake, and thanks for helping us improve our attribution process moving forward 🙇‍♂️