[IAC-43] Create Ably App Datasource

ably / terraform-provider-ably

Ably's Terraform Provider, enabling you to manage your Ably account programmatically.

https://registry.terraform.io/providers/ably/ably

Apache License 2.0

11 stars 2 forks source link

[IAC-43] Create Ably App Datasource #83

Closed graham-russell closed 1 year ago

graham-russell commented 2 years ago

Includes:

Documentation updates (terraform-docs + tfplugindocs)
Examples in resources + playground folders. Creates an app datasource and demonstrates use with tf outputs.
Ably App Datesource code + Acceptance tests
Update provider.go to expose app datasource.

Morganamilo commented 2 years ago

This is a lot of duplicated code? Will we have to do this for every resource type? Can't we do it with one type? Can we have the app resource implement the resource and data interfaces?

graham-russell commented 2 years ago

This is a lot of duplicated code? Will we have to do this for every resource type? Can't we do it with one type? Can we have the app resource implement the resource and data interfaces?

Agreed, In part, this is one of the reasons I logged this PR ahead of schedule as it'll give us time to formulate a plan on how to proceed. Let's discuss this one and agree on an approach with the team.

kavalerov commented 2 years ago

This is the new approach, right?

kavalerov commented 1 year ago

Considering that we are not likely to merge this in the near future - should we maybe move the PR into "draft" stage? It is "waiting for reviews" right now.

graham-russell commented 1 year ago

We can probably go further and close this PR for now. It can be reopened when we implement datasources. wdyr @kavalerov ?

kavalerov commented 1 year ago

Agreed. Lets do this.