ably / test-observability

A web app for storing and displaying information about unit test results.
https://test-observability.herokuapp.com/
Apache License 2.0
0 stars 1 forks source link

Misleading error messages for missing keys when creating an upload #52

Open lawrence-forooghian opened 2 years ago

lawrence-forooghian commented 2 years ago

Submitting an upload without github_base_ref / github_head_ref in the body gives a validation error e.g. 'github_base_ref must be a string'. These error messages are slightly misleading - github_base_ref and github_head_ref are nullable (i.e. you have to provide the key, but the value is allowed to be null).

Internal discussion: https://ably-real-time.slack.com/archives/C030C5YLY/p1652438829327409?thread_ts=1652428652.185689&cid=C030C5YLY

┆Issue is synchronized with this Jira Uncategorised by Unito