abmagil / haystack

An ActiveRecord-based searcher for Rails Models
MIT License
1 stars 0 forks source link

Bring in some AREL fun #8

Open abmagil opened 9 years ago

abmagil commented 9 years ago

Arel will let us do the ORing we so desperately want.

Theoretically, it will let us do the joining we want too, pending some form of design....

abmagil commented 9 years ago

or will be coming in Rails 5. Maybe time for version 1.1? :smile:

https://github.com/rails/rails/pull/16052

abmagil commented 8 years ago

This feels like a data structure built from the request, so that things must conform to a convention, then be parsed into the data structure. The data structure then gets transformed into ARel, which handles the heavy lifting.

abmagil commented 8 years ago

I'm a big dumb idiot- this is a wildly breaking change. v2.0, not 1.1... :facepalm: