Closed mkmer closed 1 year ago
I don't think I did this "right" - looks like all commits from the other PR are in here too. This should be everything needed for a single eventsocket per appliance - hopefully no new API actions appear that cause trouble.
Marking as draft (otherwise I get flooded with emails). Please mark as ready when finished.
I'll wait until the auth fix PR is approved... Sorry about the SPAM
On Fri, Sep 16, 2022 at 9:00 AM Abílio Costa @.***> wrote:
Marking as draft (otherwise I get flooded with emails). Please mark as ready when finished.
— Reply to this email directly, view it on GitHub https://github.com/abmantis/whirlpool-sixth-sense/pull/19#issuecomment-1249337796, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3GVBFBB2ZN3PFSNHBSGO3V6RVP5ANCNFSM6AAAAAAQM4YPEA . You are receiving this because you authored the thread.Message ID: @.***>
I'll wait until the auth fix PR is approved... Sorry about the SPAM … On Fri, Sep 16, 2022 at 9:00 AM Abílio Costa @.> wrote: Marking as draft (otherwise I get flooded with emails). Please mark as ready when finished. — Reply to this email directly, view it on GitHub <#19 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB3GVBFBB2ZN3PFSNHBSGO3V6RVP5ANCNFSM6AAAAAAQM4YPEA . You are receiving this because you authored the thread.Message ID: @.>
no problem! thanks for your help
No problem on the delay - no real hurry until we get the first HA PR approved. I've been fairly happy with the performance over the last few weeks - no hangups at all.
Thanks again for your help. I've just published v0.18.0 to pypi.
Remove callback from init Add register_callback(callback) to appliance - allows multiple callbacks to register with single appliance (allowing for 1 event socket/appliance)