search

abmantis / whirlpool-sixth-sense

Whirlpool unofficial API for 6th Sense appliances
MIT License
14 stars 12 forks source link

Include KitchenAid brand #26

Closed MizterB closed 1 year ago

MizterB commented 1 year ago

Enable communication with KitchenAid brand appliances

mkmer commented 1 year ago

This is an interesting development - I wonder how they do this with mixed brands on a users account... My account is brand maytag (in the US) even though the appliances are whirlpool.
I think we will have some challenges on the HA integration configuration as we move forward :(

abmantis commented 1 year ago

This is an interesting development - I wonder how they do this with mixed brands on a users account... My account is brand maytag (in the US) even though the appliances are whirlpool. I think we will have some challenges on the HA integration configuration as we move forward :(

But you use the Whirlpool app, right? The Whirlpool app here (in EU) uses the whirlpool client_id. I assume that in the US it simply uses maytag for both Whirlpool + Maytag appliances.

mkmer commented 1 year ago

Correct - I'm in the US, using whirlpool android app AND have whirlpool appliances, yet must set the maytag brand for a successful login.
So far, we didn't put a brand option on the HA config flow, and at least as far as I know, it will be confusing in the US. Now that we have a kitchenaid brand too (assuming it's needed in EU?) we will need to put the brand selector in the config flow, and it will more than likely be confusing. I suppose we could address it with the docs.

abmantis commented 1 year ago

In the Brand option, I think we could also have a default "Auto" brand, where the integration tries to auth one by one, and selects the one that succeeds.