abnamro / repository-scanner

Tool to detect secrets in source code management systems.
MIT License
152 stars 19 forks source link

Feature - Provide more storage types for persistent volume storage #235

Closed hoksanyip closed 2 days ago

hoksanyip commented 1 month ago

Is your feature request related to a problem? Please describe.

Currently, there are two options to set the storage engine of persistent volume: using parameters local and hostPath, which in both cases will store the data locally in the nodes themselves. As we are trying to set this up the cloud using server-less containers, this would not be viable. Instead, using CSI-backed storages would be would be nice to have. And given the reasonable standardised interface (for most of the drivers, it works by adding parameters in csi specs key, it can be made quite generic for most, if not all, types of CSI drivers.

Describe the solution you'd like

As an alternative to providing the hostOS in the helm values, add an option to add parameters to csi, for example, instead of the values (for example in https://github.com/abnamro/repository-scanner/blob/main/deployment/kubernetes/charts/resc-database/values.yaml):

hostOS: "windows"
database:
   pvc_path: "/var/resc/mssql/data"
  pvc_size: 10Gi

add an option to specify to store the persistent volumes in AWS EFS CSI:

database:
  ...
  storageType: "csi" 
  csi:
    driver: efs.csi.aws.com
    volumeHandle: [[fs-id]]::[[fsap-id]]

so it can directly be inserted as-is in PersistentVolume resource.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Peter-v-d-Spek commented 2 days ago

resolved with merging of proposed changes