search

abo-abo / ace-window

Quickly switch windows in Emacs
977 stars 87 forks source link

Rebased PR to sync our branches #118

Closed rswgnu closed 6 years ago

rswgnu commented 6 years ago

This is as clean as I could make it with rebase. The changes are short enough to read manually I think. Then apply and tweak any minor differences that remain. Thanks.

I updated documentation and added aw-ignore-p improvements as well. I still have to rebase the avy PR.

abo-abo commented 6 years ago

Looks like you have to rebase this PR as well - there's a merge confict.

rswgnu commented 6 years ago

I know. It is small. I was hoping you could handle that manually yourself.

rswgnu commented 6 years ago

I have made the conflicts as small as I can now. You could easily resolve these by hand (there is only one that involves a logic change) and then change anything you want.

abo-abo commented 6 years ago

Thanks. I merged as much as I could. I used a simple copy-paste approach for rebasing: Git was getting too confused.

I'm not convinced that non-selectable buffers should be highlighted in ace-window-display-mode. If you want the other changes for ace-window-display-mode, open a new PR with some explanation.

There was a bit about checking aw-action to be a window: it's not a window, it's a function like it says in the doc.

rswgnu commented 6 years ago

On Mon, Dec 11, 2017 at 11:59 AM, Oleh Krehel notifications@github.com wrote:

Thanks. I merged as much as I could. I used a simple copy-paste approach for rebasing: Git was getting too confused.

I'm not convinced that non-selectable buffers should be highlighted in ace-window-display-mode.

​For example, the Treemacs package uses a side window to display a dired-like file manager that stays in the frame until it is quit. It's sets the 'no-other-window property because its window should not generally be selected when switching windows. But at some point, you want to jump to its window and execute commands. So ace-window could provide direct access to it if it were labeled. I would think the windows you would never want to jump to at 1% or less.

There was a bit about checking aw-action to be a window: it's not a window, it's a function like it says in the doc.

​

I agree it would be better if such logic were not needed. Let me get back to you on this one.

I took it out in a small edit that I will PR to you. Thanks for your help with this.