abo-abo / ace-window

Quickly switch windows in Emacs
977 stars 87 forks source link

Window number missing in eshell #134

Closed emosesPatreon closed 5 years ago

emosesPatreon commented 6 years ago

When I have a window showing an eshell buffer, the window number is missing. It shows up fine in other buffers. Also, that window clearly has a number assigned; if I guess it correctly it works (e.g., if I have three windows open, one shows 1, one shows 3, and there's nothing in the eshell window, if I hit 2, it jumps to eshell)

Emacs-version: GNU Emacs 26.1 (build 1, x86_64-apple-darwin17.5.0, Carbon Version 158 AppKit 1561.4) of 2018-05-29 (this is the Yamamoto mac port https://bitbucket.org/mituharu/emacs-mac/)

Ace-window: version 0.9.0

abo-abo commented 6 years ago

Can't reproduce on GNU Emacs 26.1 on Linux with the latest master.

powellb commented 6 years ago

I have the same issue; however, it does not happen using the standard gnu emacs 26.1. It does occur with Yamamoto's port, so I think the issue is likely some change/difference introduced in emacs-mac.

ofenerci commented 6 years ago

I have the same issue for Emacs 26

seagle0128 commented 5 years ago

Same issue here. it's similar with #131, I think.

abo-abo commented 5 years ago

Please test.

emosesPatreon commented 5 years ago

Looks like it's working. Thanks!