search

abo-abo / ace-window

Quickly switch windows in Emacs
977 stars 87 forks source link

Last commit breaks numbering #135

Closed DamienCassou closed 6 years ago

DamienCassou commented 6 years ago

Commit "Make window ordering rely on frame position" does not work with EXWM. I don't understand what is happening and it was too annoying for me to keep using this change.

/cc @ch11ng

abo-abo commented 6 years ago

Thanks, I'll revert it for now. Can you provide any extra info on how it doesn't work? Maybe @ConnorNelson could open a second PR with a fix.

DamienCassou commented 6 years ago

Oleh Krehel notifications@github.com writes:

Thanks, I'll revert it for now. Can you provide any extra info on how it doesn't work? Maybe @ConnorNelson could open a second PR with a fix.

I think I understand what happened. I usually have 3 EXWM workspaces opened at a time (I think one workspace maps to one Emacs frame). Of these 3 workspaces, only 2 are always visible (1 workspace per screen): the workspaces 1 and 2. Workspace 0 is useless and never visible.

Before the offending commit, the useless workspace had no impact on ace-window and I could safely ignore it. After the commit, I believe that the presence of the useless workspace (whose index is 0) shifted ace-window numbering.

I believe the commit is fine and only my configuration is problematic.

-- Damien Cassou http://damiencassou.seasidehosting.st

"Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill