abo-abo / ace-window

Quickly switch windows in Emacs
970 stars 86 forks source link

Ignoring childframes #150

Closed Yevgnen closed 5 years ago

Yevgnen commented 5 years ago

Hi, now more and more package use childframe to display thing like eldoc or other informations. Accidentally I use ace-window when a childframe is being displayed and numbered by ace-window. Can childframes like this can be ignore by ace-window? Thanks.

abo-abo commented 5 years ago

Thanks.

butala commented 5 years ago

The code merged to close this issue breaks my emacs. I use emacs prelude (https://github.com/bbatsov/prelude) which sets

(global-set-key [remap other-window] 'ace-window)

But, now when I do C-x o I get the error

aw-ignored-p: Symbol’s function definition is void: frame-parent

It seems my emacs does not grok frame-parent. Is there some action I can take to fix this issue? Does this merge assume something that is different about my emacs?

9m9 commented 5 years ago

I also have this problem: Symbol’s function definition is void: frame-parent. Emacs version: GNU Emacs 25.3.1 (x86_64-slackware-linux-gnu, GTK+ Version 3.18.9) of 2017-09-13 ace-window version: 20181220.1446

butala commented 5 years ago

It seems this issue has been address in GH-151.

Eeemil commented 5 years ago

The Symbol’s function definition is void: frame-parent. is affecting me too on GNU Emacs 25.2.2 (x86_64-pc-linux-gnu, GTK+ Version 3.22.21) of 2017-09-22, modified by Debian with ace window ace-window-20181220.1446 whenever ace-window is called.

GH-151 fixes the issue though.