search

abo-abo / ace-window

Quickly switch windows in Emacs
970 stars 86 forks source link

no parent-frame in emacs 25 #152

Closed lcacciari closed 5 years ago

lcacciari commented 5 years ago

Today update broke under emacs 25.2.2, that being the default version installed on ubuntu machines.

Emacs complain about function value of symbol 'frame-parent' being void which isn't surprising as this function has been introduced in version 26.0

in fact, in the 25.2.2 version of the manual there is no section named 'Child Frames' in the 'Frames' chapter of the ELisp manual.

Khady commented 5 years ago

Debian only has 25.1.1, so is impacted too.

3452f435 commented 5 years ago

It also broke for me on Emacs 27. Changed parent-frame to frame-parent and it's solved now.

chenl commented 5 years ago

Reverting 2e3b9562b52e3ce2def3adf32f5ec8fe77f573d6 worked for me.

bymoz089 commented 5 years ago

same here, with emacs 25.

bgschaid commented 5 years ago

Fixed this temporarily with replacing the offending line with

      ;; ignore child frames
      (and
       (fboundp 'frame-parent)
       (frame-parent (window-frame window)))
      ;; Ignore selected window if `aw-ignore-current' is non-nil.
abo-abo commented 5 years ago

Thanks for reporting. This was fixed a few days ago, I believe. Please test.

bgschaid commented 5 years ago

Thanks for reporting. This was fixed a few days ago, I believe. Please test.

Updated to the latest ELPA-version and it seems to be fine now

abo-abo commented 5 years ago

Thanks, closing.