search

abo-abo / ace-window

Quickly switch windows in Emacs
970 stars 86 forks source link

Fix window highlight in hollow cursor #159

Closed bjpbakker closed 5 years ago

bjpbakker commented 5 years ago

When the cursor in non-selected windows becomes hollow, and the point is in the same position as the window label, the label becomes invisible as it is rendered with the background color of the cursor face.

Setting cursor-in-non-selected-windows to nil during selection, cursors in non-selected windows are hidden completely. Hence the window label is always visible.

abo-abo commented 5 years ago

Can't reproduce on Emacs 26.1 / Linux:

screenshot_2019-02-05_10-51-30

Setting cursor-in-non-selected-windows is a bit drastic. It's an effect that's visible to the user that does nothing useful in 99% of the cases. If we end up taking this solution, it's better to go through the window list, check if the point is at window-start and only in that case bind cursor-in-non-selected-windows locally in that one window.

bjpbakker commented 5 years ago

I noticed the issue on my work mac in Emacs 27. On my Linux with Emacs 26.1 I cannot reproduce this either.

I agree that it's somewhat drastic and can see that this change may annoy some people. I'll try dig around to pin-point the issue better, maybe it's actually an Emacs 27 bug.

Thanks for your feedback.

abo-abo commented 5 years ago

Thanks for the report, and in advance for the follow up.